Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22 japanese home page #31

Merged
merged 6 commits into from
Apr 25, 2024
Merged

22 japanese home page #31

merged 6 commits into from
Apr 25, 2024

Conversation

ann-kilzer
Copy link
Collaborator

@ann-kilzer ann-kilzer commented Apr 25, 2024 •
edited
Loading

Resolves #22

What changed 🧐

  1. Added Japanese localization to the home page
  2. snuck in updating the slack link to one that won't expire

How did you test it? 🧪

  1. Manual testing by toggling the locale switcher in the side menu
  2. New unit test that the button works
  3. Sorry I don't have time to write full tests right now 😭 but I put in a stub

@ann-kilzer ann-kilzer requested a review from sirbully as a code owner April 25, 2024 14:03
@ann-kilzer ann-kilzer self-assigned this Apr 25, 2024
@ann-kilzer ann-kilzer requested a review from RossellaFer April 25, 2024 15:25
RossellaFer
RossellaFer approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@RossellaFer RossellaFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ann-kilzer ann-kilzer merged commit e964193 into main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossellaFer RossellaFer RossellaFer approved these changes

@sirbully sirbully Awaiting requested review from sirbully sirbully is a code owner

@caitlinthebest caitlinthebest Awaiting requested review from caitlinthebest

Assignees

@ann-kilzer ann-kilzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Japanese translation for Home page
2 participants
@ann-kilzer @RossellaFer