Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: don't require l10n validator to be a composer dependency #23

Closed
JDGrimes opened this issue Feb 18, 2015 · 1 comment
Closed

Travis: don't require l10n validator to be a composer dependency #23

JDGrimes opened this issue Feb 18, 2015 · 1 comment
Assignees
@JDGrimes
Labels
enhancement
Milestone
1.1.0

Comments

@JDGrimes
Copy link
Member

We load PHPCS directly, and we should do the same for this if it isn't already a dependency. This applies to the l10n validator config as well.
@JDGrimes JDGrimes added this to the 1.1.0 milestone Feb 18, 2015
@JDGrimes JDGrimes self-assigned this Feb 18, 2015
@JDGrimes
Copy link
Member Author

To do this, we'll need to implement our own bootstrap file for the l10n validator, that will need to load the config repo's bootstrap from the correct location. Alternatively, we could make that config a part of this repo. I favor that, because it means one less thing to configure, and also it is simpler to implement.

JDGrimes added a commit that referenced this issue Feb 18, 2015
@JDGrimes
Travis: install WP L10n Validator from GitHub
ed781a2 
See #23
JDGrimes added a commit that referenced this issue Feb 18, 2015
@JDGrimes
Travis: merge l10n-validator-config
e71c188 
Rather than loading it from GitHub.

See #23
JDGrimes added a commit that referenced this issue Feb 18, 2015
@JDGrimes
Don't syntax check l10n validator config on PHP5.2
ca7c113 
See #23
JDGrimes added a commit that referenced this issue Feb 19, 2015
@JDGrimes
Travis: only run l10n validator if config file exists
5cd8dde 
See #23
JDGrimes added a commit that referenced this issue Feb 19, 2015
@JDGrimes
Travis: use correct variable
761c058 
See #23
JDGrimes added a commit that referenced this issue Feb 19, 2015
@JDGrimes
Travis: s/GITHUB_TREE/GIT_TREE/
1ce8f03 
See #23
JDGrimes added a commit that referenced this issue Feb 19, 2015
@JDGrimes
Travis: don't install composer deps for codesniff pass
5e7206b 
This really isn’t needed any longer after #23. If a project still needs
it for some reason, they can still call `setup-composer` in
`.ci-env.sh`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDGrimes JDGrimes

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@JDGrimes