Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all HTML classes #634

Open
JDGrimes opened this issue Feb 26, 2017 · 1 comment
Open

Prefix all HTML classes #634

JDGrimes opened this issue Feb 26, 2017 · 1 comment
Milestone

Comments

@JDGrimes
Copy link
Member

We prefix all of our main HTML classes (like .wordpoints-hook-reaction), but not the modifier classes (.new, .edited) or sub-element classes (.view, .action). I've considered possibly prefixing them all before, but I figured the potential for conflicts with other plugins or core woudl be reduced because we'd never reference these independently, they'd always be qualified with the prefixed class in some way. However, that only prevents us from braking most other stuff, it doesn't prevent it from breaking our stuff (see Automattic/Edit-Flow#351 (comment)). Prefixing all of the classes is long, it is ugly, and it isn't fair. But in any other place in code, we wouldn't dare fail to prefix, so why here? It will make things more robust, resulting in a better UX for our users. Even if it is painful for me.

The main question will be how to handle back-compat here, I guess there might need to be a transitional period where we use both the prefixed and unprefixed things everywhere, before we remove the unprefixed versions entirely. Although during that transitional period any conflicts will continue.

@JDGrimes JDGrimes added this to the 2.4.0 milestone Feb 26, 2017
@JDGrimes
Copy link
Member Author

JDGrimes commented May 7, 2017

Related: WP#40686.

@JDGrimes JDGrimes modified the milestones: 2.4.0, 2.5.0 Aug 31, 2017
@JDGrimes JDGrimes modified the milestones: 2.5.0, Gutenburg Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant