You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just run into a plugin conflict caused by calendar.js. The function listening to $(document).click() was getting called on a plugin's admin screen, since it is loaded on every page in the admin. That results in reset_editorial_metadata() getting called, via edit_flow_calendar_close_overlays(). This will hide all elements on the page with the .editing class being hidden. My plugin WordPoints uses the .editing class on the WordPoints » Points Types admin screen, and so I received a report that a user who was testing out the plugin was clicking a button that was supposed to add an element to the screen, but the element was being hidden as soon as it was added, because it had the .editing class.
The code in calendar.js is just asking for conflicts. It should not only be loaded only where needed, but it should use more specific selectors, instead of targeting every single element on the entire screen via a generic class.
Sometimes we check if we should load CSS and JS on a given page, sometimes we don't.
A patch for this issue would make it so a module's CSS and JS is loaded only when necessary instead of on every page in the admin.
This is consolidating tickets #239 and #242. Exists because of #263. Might also help scope (but not solve) cases like #323.
The text was updated successfully, but these errors were encountered: