Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog for version 0.11.0 #866

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Changelog for version 0.11.0 #866

merged 1 commit into from
Mar 18, 2017

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 6, 2017 •
edited
Loading

Ok, finished... & ready for review 🎉

Looking at the changelog now, I kind of think we may need to release new versions more often...

@jrfnl jrfnl added this to the 0.11.0 milestone Mar 6, 2017
@GaryJones
Copy link
Member

I kind of think we may need to release new versions more often

We originally said release should be on a monthly basis.

JDGrimes
JDGrimes approved these changes Mar 9, 2017
View reviewed changes
Copy link
Contributor

@JDGrimes JDGrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work @jrfnl!

CHANGELOG.md Outdated
- The `WordPress.Arrays.ArrayDeclaration` sniff has been split into two sniffs: `WordPress.Arrays.ArrayDeclaration` and `WordPress.Arrays.ArrayDeclarationSpacing` for better compatibility with PHPCS upstream.
- The `WordPress.Arrays.ArrayDeclaration` sniff has been synced with the PHPCS upstream version to get the benefit of some bug fixes and improvements which had been made upstream since the sniff was originally copied over.
- The `WordPress.VIP.FileSystemWritesDisallow`, `WordPress.VIP.TimezoneChange` and `WordPress.VIP.SessionFunctionsUsage` sniffs now extend the `WordPress_AbstractFunctionRestrictionsSniff`.
- Property handling of custom properties set via a custom ruleset where the property is expected to be set in array format (`type=""array"`) has been made more lenient and will now also handle properties passed as a comma delimited lists correctly. This affects all customizable properties which expect array format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra quote in type=""array"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that one. Fixed now.

@JDGrimes
Copy link
Contributor

JDGrimes commented Mar 9, 2017

We originally said release should be on a monthly basis.

Monthly might be too quick sometimes, depending on how active contribution is. But as long as there are a few significant changes at the end of the month, I think we should go ahead and drop a release. I just need to be better about actually setting aside the time to do it (sometimes easy, sometimes not).

GaryJones
GaryJones approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not checked for what might be missing, but couldn't spot any issues with what's here. Really fantastic dedication to the project @jrfnl. Thank you.

@jrfnl
Copy link
Member Author

jrfnl commented Mar 10, 2017

Releases based on time often become quite forced. What about something along the lines of: if there are twenty (arbitrary number) or more merged PRs and no on-going PR-chains (like the recent one with all the internal changes building onto each other and having to be pulled one by one as they would conflict) ?

@jrfnl
Copy link
Member Author

jrfnl commented Mar 10, 2017

I've not checked for what might be missing

FYI: I went through all the merged PRs, but I've grouped the entries for numerous PRs together where appropriate and - logically - not made separate entries for bugs in features which were freshly introduced in this release.
I've glossed over a lot of the internal changes, while still trying to give enough pointers for sniff devs building onto WPCS.

westonruter
westonruter approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrfnl astonishingly impressive work 👏

@jrfnl jrfnl merged commit a61569e into develop Mar 18, 2017
@jrfnl jrfnl deleted the feature/changelog-0.11.0 branch March 18, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones approved these changes

@westonruter westonruter westonruter approved these changes

@JDGrimes JDGrimes JDGrimes approved these changes

Assignees
No one assigned
Labels
Type: Chores/Cleanup
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jrfnl @GaryJones @JDGrimes @westonruter