Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Add: confirmation before revoking password #119

Merged

Conversation

dinhtungdu
Copy link
Contributor

This PR adds a confirmation box when users click on revoke password buttons. This is the replacement for #23.
Resolve #17.

@TimothyBJacobs
Copy link
Member

Thanks for the patch @dinhtungdu!

Could you open this as a Pull Request to the add/application-passwords branch in https://github.com/georgestephanis/wordpress-develop/tree/add/application-passwords.

Copy link
Collaborator

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @dinhtungdu!

@dinhtungdu
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revoking Passwords: Should we have a confirmation dialog
3 participants