Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add client-side navigation support for wp-ignore directive #163

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

DAreRodz
Copy link
Collaborator

What

Allows elements with the wp-ignore directive to keep their content after navigate calls.

Why

During navigations, the content inside elements with wp-ignore could change, and those updates should not be reflected (those parts of the HTML document should be ignored).

How

Implementing the ignore directive in a way that:

  1. its content it's not parsed.
  2. the value for the dangerouslySetInnerHTML prop never changes.

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 🙂

e2e/tovdom-full.spec.ts Show resolved Hide resolved
@DAreRodz DAreRodz merged commit 510452f into main-wp-directives-plugin Mar 3, 2023
@DAreRodz DAreRodz deleted the wp-ignore-with-csn-support branch March 3, 2023 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants