Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Remove _wrapped, expose directives and expose full store #223

Merged

Conversation

luisherranz
Copy link
Member

What

  • Remove the _wrapper prop.
  • Keep directives in the DOM.
  • Pass the whole store to evaluate.

Why

  • Remove the _wrapper prop: because sometimes it's leaked to the DOM.
  • Keep directives in the DOM: to avoid confusion when inspecting the DOM while coding.
  • Pass the whole store to evaluate (instead of just state): to be able to access other arbitrary store properties in the callbacks, like selectors.

How

It's explained in this video.

https://www.loom.com/share/049ef0e25cf244d593a77466d04139cd

Copy link
Collaborator

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 ✅

@DAreRodz DAreRodz merged commit fcde2a8 into main-wp-directives-plugin Apr 21, 2023
@DAreRodz DAreRodz deleted the remove-wrapper-expose-directives-and-store branch April 21, 2023 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants