This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Support className and style blockProps on block wrapper #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2022
|
I'm resolving the conflicts with my refactor on d61391c. |
|
I think everything should be fine again. |
|
Okay, I think I managed to figure out dynamic setting of (It's pretty much like we thought it should work during our pairing. I think that we'd gotten stuck due to poor choice of values for |
luisherranz
approved these changes
Jul 25, 2022
luisherranz
deleted the
add/block-supports-classes-and-styles-on-block-wrapper
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36.
This is the result from a pair-programming session with @luisherranz.
Use the server-side implementation of the block-supports mechanism to communicate block props as
data-HTML attributes to the interactive Gutenberg block (custom element) on the frontend.For an alternative approach we tried earlier (but that didn't work), see #36 (comment).
TODO:
styleblockProps also work.