Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add figcaption escaping for image and video blocks #745

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Add figcaption escaping for image and video blocks #745

merged 2 commits into from
Nov 11, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

  • Adds figcaption escaping for image and video blocks
  • Updates the image block text locale test
  • Adds video block text locale test

Why?

Fixes: #735

@matiasbenedetto matiasbenedetto mentioned this pull request Nov 7, 2024
Closed
mikachan
mikachan approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me on video and image blocks 👏 And I can see it fixes the issue described in #735.

Video block:

image

Image block:

image

Thank you!

@matiasbenedetto matiasbenedetto merged commit ea309e0 into trunk Nov 11, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the add/escape-figacption-for-video-and-image-blocks branch November 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figcaption doesn't become translation ready
2 participants
@matiasbenedetto @mikachan