Skip to content

Update docs to avoid recommending early return PHP "anti-pattern" #95042

Update docs to avoid recommending early return PHP "anti-pattern"

Update docs to avoid recommending early return PHP "anti-pattern" #95042

Triggered via pull request January 30, 2024 14:58
Status Success
Total duration 18m 51s
Artifacts 2

end2end-test.yml

on: pull_request
Matrix: e2e-playwright
Report to GitHub
3m 55s
Report to GitHub
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 10 warnings, and 8 notices
[chromium] › interactivity/directive-on-window.spec.ts:21:6 › data-wp-on-window › callbacks should run whenever the specified event is dispatched: test/e2e/specs/interactivity/directive-on-window.spec.ts#L26
1) [chromium] › interactivity/directive-on-window.spec.ts:21:6 › data-wp-on-window › callbacks should run whenever the specified event is dispatched Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: getByTestId('counter') Expected string: "1" Received string: "0" Call log: - expect.toHaveText with timeout 5000ms - waiting for getByTestId('counter') - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" - locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p> - unexpected value "0" 24 | await page.setViewportSize( { width: 600, height: 600 } ); 25 | const counter = page.getByTestId( 'counter' ); > 26 | await expect( counter ).toHaveText( '1' ); | ^ 27 | } ); 28 | test( 'the event listener is removed when the element is removed', async ( { 29 | page, at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/directive-on-window.spec.ts:26:27
[chromium] › interactivity/tovdom-islands.spec.ts:42:6 › toVdom - islands › directives inside islands should not be hydrated twice: test/e2e/specs/interactivity/tovdom-islands.spec.ts#L47
2) [chromium] › interactivity/tovdom-islands.spec.ts:42:6 › toVdom - islands › directives inside islands should not be hydrated twice Error: expect(received).toEqual(expected) // deep equality Expected: 1 Received: 0 45 | const el = page.getByTestId( 'island inside another island' ); 46 | const templates = el.locator( 'template' ); > 47 | expect( await templates.count() ).toEqual( 1 ); | ^ 48 | } ); 49 | 50 | test( 'islands inside inner blocks of isolated islands should be hydrated', async ( { at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/tovdom-islands.spec.ts:47:37
🎭 Playwright Run Summary
4 skipped 120 passed (6.2m)
🎭 Playwright Run Summary
168 passed (7.6m)
🎭 Playwright Run Summary
11 skipped 150 passed (7.8m)
🎭 Playwright Run Summary
2 flaky [chromium] › interactivity/directive-on-window.spec.ts:21:6 › data-wp-on-window › callbacks should run whenever the specified event is dispatched [chromium] › interactivity/tovdom-islands.spec.ts:42:6 › toVdom - islands › directives inside islands should not be hydrated twice 176 passed (7.5m)
🎭 Playwright Run Summary
1 skipped 143 passed (7.8m)
🎭 Playwright Run Summary
1 skipped 148 passed (8.0m)
🎭 Playwright Run Summary
3 skipped 119 passed (7.5m)
🎭 Playwright Run Summary
158 passed (7.9m)
Puppeteer
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 6
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 5
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 7
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 2
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 4
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 8
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Playwright - 3
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Report to GitHub
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c, actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8, ./packages/report-flaky-tests. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Artifacts

Produced during runtime
Name Size
failures-artifacts Expired
1.49 MB
flaky-tests-report Expired
2.09 KB