Fix unit tests for useSetting, run hooks inside React render

WordPress · Oct 13, 2023 · 21134f9 · 21134f9
1 parent 7afc068
commit 21134f9
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/use-setting/test/index.js b/packages/block-editor/src/components/use-setting/test/index.js
@@ -1,8 +1,14 @@
+/**
+ * External dependencies
+ */
+import { render } from '@testing-library/react';
+
 /**
  * WordPress dependencies
  */
 import { addFilter, removeFilter } from '@wordpress/hooks';
 import { useSelect } from '@wordpress/data';
+import { useEffect } from '@wordpress/element';
 
 /**
  * Internal dependencies
@@ -38,6 +44,18 @@ const mockCurrentBlockContext = (
 	);
 };
 
+function runHook( hookCb ) {
+	let storedResult;
+	function TestHook() {
+		const result = hookCb();
+		useEffect( () => {
+			storedResult = result;
+		}, [ result ] );
+	}
+	render( <TestHook /> );
+	return storedResult;
+}
+
 describe( 'useSetting', () => {
 	beforeEach( () => {
 		setupSelectMock();
@@ -59,7 +77,8 @@ describe( 'useSetting', () => {
 			name: 'core/test-block',
 		} );
 
-		expect( useSetting( 'layout.contentSize' ) ).toBe( '840px' );
+		const result = runHook( () => useSetting( 'layout.contentSize' ) );
+		expect( result ).toBe( '840px' );
 	} );
 
 	it( 'uses blockEditor.useSetting.before hook override', () => {
@@ -89,7 +108,8 @@ describe( 'useSetting', () => {
 			}
 		);
 
-		expect( useSetting( 'layout.contentSize' ) ).toBe( '960px' );
+		const result = runHook( () => useSetting( 'layout.contentSize' ) );
+		expect( result ).toBe( '960px' );
 
 		removeFilter(
 			'blockEditor.useSetting.before',