Clarify implementation only attributes

WordPress · May 17, 2018 · 2e88f72 · 2e88f72
1 parent 7fefed2
commit 2e88f72
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/blocks/api/registration.js b/blocks/api/registration.js
@@ -146,12 +146,13 @@ export function registerBlockType( name, settings ) {
 		set( settings, [ 'supports', 'inserter' ], ! settings.isPrivate );
 	}
 
-	const blockTypeDefinition = omit( settings, [ 'transforms', 'edit', 'save', 'icon', 'getEditWrapperProps' ] );
+	const implementationOnlyAttributes = [ 'transforms', 'edit', 'save', 'icon', 'getEditWrapperProps' ];
+	const blockTypeDefinition = omit( settings, implementationOnlyAttributes );
 	blockTypeDefinition.attributes = mapValues(
 		settings.attributes,
 		( attribute ) => pick( attribute, [ 'type', 'default' ] )
 	);
-	const blockTypeImplementation = pick( settings, [ 'name', 'transforms', 'edit', 'save', 'icon', 'getEditWrapperProps' ] );
+	const blockTypeImplementation = pick( settings, [ 'name' ].concat( implementationOnlyAttributes ) );
 	blockTypeImplementation.attributes = mapValues(
 		settings.attributes,
 		( attribute ) => omit( attribute, [ 'type', 'default' ] )