Make sure the mobile warning notice only runs when images are added t…

…o a new gallery block (#36326) Co-authored-by: Glen Davies <glen.davies@a8c.com>
WordPress · Nov 10, 2021 · 369a056 · 369a056
1 parent 00b7a54
commit 369a056
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/block-library/src/gallery/edit.js b/packages/block-library/src/gallery/edit.js
@@ -97,7 +97,7 @@ function GalleryEdit( props ) {
 		shortCodeTransforms,
 		sizeSlug,
 	} = attributes;
-	useMobileWarning();
+
 	const {
 		__unstableMarkNextChangeAsNotPersistent,
 		replaceInnerBlocks,
@@ -139,6 +139,8 @@ function GalleryEdit( props ) {
 
 	const newImages = useGetNewImages( images, imageData );
 
+	useMobileWarning( newImages );
+
 	useEffect( () => {
 		newImages?.forEach( ( newImage ) => {
 			updateBlockAttributes( newImage.clientId, {

diff --git a/packages/block-library/src/gallery/use-mobile-warning.js b/packages/block-library/src/gallery/use-mobile-warning.js
@@ -6,15 +6,15 @@ import { useDispatch, useSelect } from '@wordpress/data';
 import { store as interfaceStore } from '@wordpress/interface';
 import { store as noticesStore } from '@wordpress/notices';
 
-export default function useMobileWarning() {
+export default function useMobileWarning( newImages ) {
 	const { createWarningNotice } = useDispatch( noticesStore );
 	const { toggleFeature } = useDispatch( interfaceStore );
 	const isMobileWarningActive = useSelect( ( select ) => {
 		const { isFeatureActive } = select( interfaceStore );
 		return isFeatureActive( 'core/edit-post', 'mobileGalleryWarning' );
 	}, [] );
 
-	if ( ! isMobileWarningActive ) {
+	if ( ! isMobileWarningActive || ! newImages ) {
 		return;
 	}