Small changes per review

WordPress · Jun 20, 2018 · 3d1fd0c · 3d1fd0c
1 parent feb0600
commit 3d1fd0c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/blocks/store/actions.js b/blocks/store/actions.js
@@ -18,7 +18,7 @@ export function addBlockTypes( blockTypes ) {
 }
 
 /**
- * Returns an action object used in signalling that block types have been added.
+ * Returns an action object used in signalling that block types have been implemented.
  *
  * @param {Array|Object} implementations Block types implementations.
  *

diff --git a/blocks/store/selectors.js b/blocks/store/selectors.js
@@ -2,7 +2,7 @@
  * External dependencies
  */
 import createSelector from 'rememo';
-import { filter, includes, map, mapValues, compact } from 'lodash';
+import { filter, includes, map, mapValues, compact, get } from 'lodash';
 
 /**
  * Returns all the available block types.
@@ -40,7 +40,7 @@ export const getBlockType = createSelector(
 			...blockTypeDefinition,
 			...blockTypeImplementation,
 			attributes: mapValues( blockTypeDefinition.attributes, ( attribute, key ) => {
-				const implementationAttribute = blockTypeImplementation.attributes ? blockTypeImplementation.attributes[ key ] : {};
+				const implementationAttribute = get( blockTypeImplementation.attributes, [ key ], {} );
 				return {
 					...attribute,
 					...implementationAttribute,
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,7 @@ export function addBlockTypes( blockTypes ) { @@
     }
     /**
-     * Returns an action object used in signalling that block types have been added.
+     * Returns an action object used in signalling that block types have been implemented.
      *
      * @param {Array|Object} implementations Block types implementations.
      *
@@ Expand Down @@