Fix dirty checking

WordPress · Jul 5, 2018 · 4b31c23 · 4b31c23
1 parent 89860a4
commit 4b31c23
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/editor/components/rich-text/annotations/annotation.js b/editor/components/rich-text/annotations/annotation.js
@@ -56,6 +56,7 @@ class Annotation extends Component {
 			startNode = this.matchEditorXPath( startXPath );
 			endNode = this.matchEditorXPath( endXPath );
 		} catch ( e ) {
+			console.log( "Couldn't match XPath", e );
 			return;
 		}
 
@@ -94,11 +95,13 @@ class Annotation extends Component {
 	}
 
 	static getDerivedStateFromProps( props, state ) {
-		const isDirty = ! isEqual( props.annotation, state.prevAnnotation );
+		if ( ! isEqual( props.annotation, state.prevAnnotation ) ) {
+			return {
+				isDirty: true,
+			};
+		}
 
-		return {
-			isDirty,
-		};
+		return {};
 	}
 
 	render() {