[Mobile] - Crash fixes when pasting HTML content (#60676)

* Mobile - JSdom - Add dataset polyfill * Mobile - image-corrector - Set empty src attribute for file: values * Mobile - Jest config - Enable special-comment-converter tests * Update Changelog * Replace const name Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
WordPress · Apr 24, 2024 · 562e10a · 562e10a
1 parent 58b8abc
commit 562e10a
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 1 deletion.
diff --git a/packages/blocks/src/api/raw-handling/image-corrector.native.js b/packages/blocks/src/api/raw-handling/image-corrector.native.js
@@ -10,6 +10,10 @@ export default function imageCorrector( node ) {
 		return;
 	}
 
+	if ( node.src.indexOf( 'file:' ) === 0 ) {
+		node.setAttribute( 'src', '' );
+	}
+
 	// Remove trackers and hardly visible images.
 	if ( node.height === 1 || node.width === 1 ) {
 		node.parentNode.removeChild( node );

diff --git a/packages/react-native-editor/CHANGELOG.md b/packages/react-native-editor/CHANGELOG.md
@@ -10,6 +10,7 @@ For each user feature we should also add a importance categorization label  to i
 -->
 
 ## Unreleased
+-   [*] Fix a crash when pasting file images and special comment markup [#60476]
 
 ## 1.117.0
 -   [*] Add empty fallback option for the BottomSheetSelectControl component [#60333]

diff --git a/packages/react-native-editor/src/jsdom-patches.js b/packages/react-native-editor/src/jsdom-patches.js
@@ -257,6 +257,37 @@ Object.defineProperties( Node.prototype, {
 			return sibling;
 		},
 	},
+	dataset: {
+		get() {
+			const node = this;
+
+			// Helper function to convert property name to data-* attribute name
+			function toDataAttributeName( property ) {
+				return (
+					'data-' +
+					property.replace(
+						/[A-Z]/g,
+						( match ) => '-' + match.toLowerCase()
+					)
+				);
+			}
+			return new Proxy(
+				{},
+				{
+					set( _target, property, value ) {
+						const attributeName = toDataAttributeName( property );
+						node.setAttribute( attributeName, value );
+						return true;
+					},
+					get( _target, property ) {
+						const attributeName = toDataAttributeName( property );
+						return node.getAttribute( attributeName );
+					},
+				}
+			);
+		},
+		set() {},
+	},
 } );
 
 class DOMParser {

diff --git a/test/native/jest.config.js b/test/native/jest.config.js
@@ -25,7 +25,6 @@ const RAW_HANDLING_UNSUPPORTED_UNIT_TESTS = [
 	'html-formatting-remover',
 	'phrasing-content-reducer',
 	'figure-content-reducer',
-	'special-comment-converter',
 	'normalise-blocks',
 	'image-corrector',
 ];