Add role=presentation to li elements in editor

WordPress · Nov 18, 2024 · 64ca1c9 · 64ca1c9
1 parent 22d205e
commit 64ca1c9
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/block-library/src/social-link/edit.js b/packages/block-library/src/social-link/edit.js
@@ -182,7 +182,13 @@ const SocialLinkEdit = ( {
 					onChange={ ( value ) => setAttributes( { rel: value } ) }
 				/>
 			</InspectorControls>
+			{ /*
+			 * Because the `<ul>` element has a role=document, the `<li>` is
+			 * not semantically correct, so adding role=presentation is cleaner.
+			 * https://github.com/WordPress/gutenberg/pull/64883#issuecomment-2472874551
+			 */ }
 			<li
+				role="presentation"
 				className={ wrapperClasses }
 				style={ {
 					color: iconColorValue,