Skip to content

Commit

Permalink
Button: Fix ESLint warning (#62126)
Browse files Browse the repository at this point in the history
* Button: Fix ESLint warning
* Include fixes for the Image block

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
  • Loading branch information
3 people authored May 30, 2024
1 parent 1ec58db commit 6c9b70f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/block-library/src/button/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ function ButtonEdit( props ) {
blockBindingsSource?.lockAttributesEditing() ),
};
},
[ isSelected ]
[ isSelected, metadata?.bindings?.url ]
);

return (
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/image/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export function ImageEdit( {
scale: undefined,
} );
}
}, [ align ] );
}, [ __unstableMarkNextChangeAsNotPersistent, align, setAttributes ] );

const { getSettings } = useSelect( blockEditorStore );
const blockEditingMode = useBlockEditingMode();
Expand Down Expand Up @@ -328,7 +328,7 @@ export function ImageEdit( {
: __( 'Connected to dynamic data' ),
};
},
[ isSingleSelected ]
[ isSingleSelected, metadata?.bindings?.url ]
);
const placeholder = ( content ) => {
return (
Expand Down

0 comments on commit 6c9b70f

Please sign in to comment.