Clean up code, reduce diff for easier reviewing

WordPress · Sep 20, 2024 · 86d61f5 · 86d61f5
1 parent cc1f7df
commit 86d61f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/components/src/navigator/navigator-screen/component.tsx b/packages/components/src/navigator/navigator-screen/component.tsx
@@ -40,12 +40,8 @@ function UnconnectedNavigatorScreen(
 		);
 	}
 
-	// Generate a unique ID for the screen.
 	const screenId = useId();
 
-	const wrapperRef = useRef< HTMLDivElement >( null );
-	const mergedWrapperRef = useMergeRefs( [ forwardedRef, wrapperRef ] );
-
 	const {
 		children,
 		className,
@@ -59,6 +55,7 @@ function UnconnectedNavigatorScreen(
 	const { isInitial, isBack, focusTargetSelector, skipFocus } = location;
 
 	const isMatch = match === screenId;
+	const wrapperRef = useRef< HTMLDivElement >( null );
 	const skipAnimationAndFocusRestoration = !! isInitial && ! isBack;
 
 	// Register / unregister screen with the navigator context.
@@ -142,6 +139,8 @@ function UnconnectedNavigatorScreen(
 		skipFocus,
 	] );
 
+	const mergedWrapperRef = useMergeRefs( [ forwardedRef, wrapperRef ] );
+
 	return shouldRenderScreen ? (
 		<View
 			ref={ mergedWrapperRef }

diff --git a/packages/components/src/navigator/navigator-screen/use-screen-animate-presence.ts b/packages/components/src/navigator/navigator-screen/use-screen-animate-presence.ts
@@ -58,7 +58,6 @@ export function useScreenAnimatePresence( {
 	skipAnimation: boolean;
 	isBack?: boolean;
 	onAnimationEnd?: React.AnimationEventHandler< Element >;
-	screenEl?: HTMLElement | null;
 } ) {
 	const isRTL = isRTLFn();
 	const prefersReducedMotion = useReducedMotion();
@@ -67,8 +66,8 @@ export function useScreenAnimatePresence( {
 		useState< AnimationStatus >( 'INITIAL' );
 
 	// Start enter and exit animations when the screen is selected or deselected.
-	// The animation status is set to `*_END` immediately if the animation should
-	// be skipped.
+	// The animation status is set to `IN` or `OUT` immediately if the animation
+	// should be skipped.
 	const becameSelected =
 		animationStatus !== 'ANIMATING_IN' &&
 		animationStatus !== 'IN' &&