DOM: Avoid consolidating unnamed radio inputs

WordPress · Feb 27, 2019 · 956cf39 · 956cf39
1 parent 01ee13c
commit 956cf39
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/dom/src/tabbable.js b/packages/dom/src/tabbable.js
@@ -50,7 +50,7 @@ function createStatefulCollapseRadioGroup() {
 		const { nodeName, type, checked, name } = element;
 
 		// For all non-radio tabbables, construct to array by concatenating.
-		if ( nodeName !== 'INPUT' || type !== 'radio' ) {
+		if ( nodeName !== 'INPUT' || type !== 'radio' || ! name ) {
 			return result.concat( element );
 		}
 

diff --git a/packages/dom/src/test/tabbable.js b/packages/dom/src/test/tabbable.js
@@ -104,5 +104,29 @@ describe( 'tabbable', () => {
 				thirdRadio,
 			] );
 		} );
+
+		it( 'not consolidate unnamed radio inputs', () => {
+			const node = createElement( 'div' );
+			const firstRadio = createElement( 'input' );
+			firstRadio.type = 'radio';
+			firstRadio.value = 'firstRadio';
+			const text = createElement( 'input' );
+			text.type = 'text';
+			text.name = 'b';
+			const secondRadio = createElement( 'input' );
+			secondRadio.type = 'radio';
+			secondRadio.value = 'secondRadio';
+			node.appendChild( firstRadio );
+			node.appendChild( text );
+			node.appendChild( secondRadio );
+
+			const tabbables = find( node );
+
+			expect( tabbables ).toEqual( [
+				firstRadio,
+				text,
+				secondRadio,
+			] );
+		} );
 	} );
 } );