Revert removal of apiVersion for JS code

We miss the mapping layer during registration that would transform kyes from PHP to JS.
WordPress · Feb 10, 2021 · 9b01bfd · 9b01bfd
1 parent 5b6d8a1
commit 9b01bfd
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/.wp-env.json b/.wp-env.json
@@ -1,9 +1,12 @@
 {
 	"core": "WordPress/WordPress",
 	"plugins": [
-		"."
+		".",
+		"./esnext-exampl"
+	],
+	"themes": [
+		"WordPress/theme-experiments/tt1-blocks#tt1-blocks@0.4.3"
 	],
-	"themes": [ "WordPress/theme-experiments/tt1-blocks#tt1-blocks@0.4.3" ],
 	"env": {
 		"tests": {
 			"mappings": {

diff --git a/packages/create-block-tutorial-template/templates/src/index.js.mustache b/packages/create-block-tutorial-template/templates/src/index.js.mustache
@@ -28,6 +28,11 @@ import save from './save';
  * @see https://developer.wordpress.org/block-editor/developers/block-api/#registering-a-block
  */
 registerBlockType( '{{namespace}}/{{slug}}', {
+	/**
+	 * @see https://make.wordpress.org/core/2020/11/18/block-api-version-2/
+	 */
+	apiVersion: {{apiVersion}},
+
 	/**
 	 * Used to construct a preview for the block to be shown in the block inserter.
 	 */

diff --git a/packages/create-block/lib/init-block-json.js b/packages/create-block/lib/init-block-json.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-const { isEmpty, omitBy } = require( 'lodash' );
+const { omitBy } = require( 'lodash' );
 const { join } = require( 'path' );
 const { writeFile } = require( 'fs' ).promises;
 
@@ -46,7 +46,7 @@ module.exports = async ( {
 					editorStyle,
 					style,
 				},
-				isEmpty
+				( value ) => ! value
 			),
 			null,
 			'\t'

diff --git a/packages/create-block/lib/templates/esnext/src/index.js.mustache b/packages/create-block/lib/templates/esnext/src/index.js.mustache
@@ -26,6 +26,11 @@ import save from './save';
  * @see https://developer.wordpress.org/block-editor/developers/block-api/#registering-a-block
  */
 registerBlockType( '{{namespace}}/{{slug}}', {
+	/**
+	 * @see https://make.wordpress.org/core/2020/11/18/block-api-version-2/
+	 */
+	apiVersion: {{apiVersion}},
+
 	/**
 	 * @see ./edit.js
 	 */