revert generation of class names for shadows

WordPress · Jan 22, 2024 · 9dc33f5 · 9dc33f5
1 parent 82ceb7a
commit 9dc33f5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/lib/block-supports/shadow.php b/lib/block-supports/shadow.php
@@ -58,7 +58,7 @@ function gutenberg_apply_shadow_support( $block_type, $block_attributes ) {
 	$shadow_block_styles['shadow'] = $preset_shadow ? $preset_shadow : $custom_shadow;
 
 	$attributes = array();
-	$styles     = gutenberg_style_engine_get_styles( $shadow_block_styles, array( 'convert_vars_to_classnames' => true ) );
+	$styles     = gutenberg_style_engine_get_styles( $shadow_block_styles );
 
 	if ( ! empty( $styles['css'] ) ) {
 		$attributes['style'] = $styles['css'];

diff --git a/lib/class-wp-theme-json-gutenberg.php b/lib/class-wp-theme-json-gutenberg.php
@@ -186,9 +186,7 @@ class WP_Theme_JSON_Gutenberg {
 			'use_default_names' => false,
 			'value_key'         => 'shadow',
 			'css_vars'          => '--wp--preset--shadow--$slug',
-			'classes'           => array(
-				'.has-$slug-shadow' => 'box-shadow',
-			),
+			'classes'           => array(),
 			'properties'        => array( 'box-shadow' ),
 		),
 	);

diff --git a/packages/block-editor/src/components/global-styles/effects-panel.js b/packages/block-editor/src/components/global-styles/effects-panel.js
@@ -88,7 +88,7 @@ export default function EffectsPanel( {
 		: [];
 	const setShadow = ( newValue ) => {
 		const slug = mergedShadowPresets?.find(
-			( { shadow: s } ) => s === newValue
+			( { shadow: shadowName } ) => shadowName === newValue
 		)?.slug;
 
 		onChange(

diff --git a/packages/style-engine/class-wp-style-engine.php b/packages/style-engine/class-wp-style-engine.php
@@ -182,10 +182,6 @@ final class WP_Style_Engine {
 				'css_vars'      => array(
 					'shadow' => '--wp--preset--shadow--$slug',
 				),
-				'classnames'    => array(
-					'has-shadow'       => true,
-					'has-$slug-shadow' => 'shadow',
-				),
 			),
 		),
 		'dimensions' => array(