move the filter inside the useMemo

packages/edit-site/src/hooks/use-theme-style-variations/use-theme-style-variations-by-property.js

@@ -84,7 +84,7 @@ export function useCurrentMergeThemeStyleVariationsWithUserConfig( property ) {
 	}, [] );
 	const { user: userVariation } = useContext( GlobalStylesContext );
 
-	const variationsByProperty = useMemo( () => {
+	return useMemo( () => {
 		const clonedUserVariation = cloneDeep( userVariation );
 
 		// Get user variation and remove the settings for the given property.
@@ -105,20 +105,20 @@ export function useCurrentMergeThemeStyleVariationsWithUserConfig( property ) {
 				);
 			} );
 
-		return [
+		const variationsByProperty = [
 			userVariationWithoutProperty,
 			...variationsWithSinglePropertyAndBase,
 		];
-	}, [ property, userVariation, variationsFromTheme ] );
 
-	/*
-	 * Filter out variations with no settings or styles.
-	 */
-	return variationsByProperty?.length
-		? variationsByProperty.filter(
-				( variation ) => ! isEmptyStyleVariation( variation )
-		  )
-		: [];
+		/*
+		 * Filter out variations with no settings or styles.
+		 */
+		return variationsByProperty?.length
+			? variationsByProperty.filter(
+					( variation ) => ! isEmptyStyleVariation( variation )
+			  )
+			: [];
+	}, [ property, userVariation, variationsFromTheme ] );
 }
 
 /**