Insert in correct location for root insertions

WordPress · Sep 10, 2024 · a90bb7f · a90bb7f
1 parent efa5ffe
commit a90bb7f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/packages/block-editor/src/components/inserter/hooks/use-insertion-point.js b/packages/block-editor/src/components/inserter/hooks/use-insertion-point.js
@@ -82,23 +82,21 @@ function useInsertionPoint( {
 				getInserterInsertionPoint,
 			} = unlock( select( blockEditorStore ) );
 			const selectedBlockClientId = getSelectedBlockClientId();
-
 			let _destinationRootClientId = rootClientId;
 			let _destinationIndex;
 			const insertionPoint = getInserterInsertionPoint();
 
 			if ( insertionIndex !== undefined ) {
 				// Insert into a specific index.
 				_destinationIndex = insertionIndex;
+			} else if ( insertionPoint?.insertionIndex ) {
+				_destinationRootClientId = insertionPoint?.rootClientId
+					? insertionPoint.rootClientId
+					: rootClientId;
+				_destinationIndex = insertionPoint.insertionIndex;
 			} else if ( clientId ) {
 				// Insert after a specific client ID.
 				_destinationIndex = getBlockIndex( clientId );
-			} else if (
-				insertionPoint?.insertionIndex &&
-				insertionPoint?.rootClientId
-			) {
-				_destinationRootClientId = insertionPoint.rootClientId;
-				_destinationIndex = insertionPoint.insertionIndex;
 			} else if ( ! isAppender && selectedBlockClientId ) {
 				_destinationRootClientId = getBlockRootClientId(
 					selectedBlockClientId

diff --git a/packages/block-editor/src/components/inserter/quick-inserter.js b/packages/block-editor/src/components/inserter/quick-inserter.js
@@ -9,7 +9,7 @@ import clsx from 'clsx';
 import { useState, useEffect } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
 import { Button, SearchControl } from '@wordpress/components';
-import { useSelect } from '@wordpress/data';
+import { useDispatch, useSelect } from '@wordpress/data';
 
 /**
  * Internal dependencies
@@ -83,7 +83,7 @@ export default function QuickInserter( {
 		}
 	}, [ setInserterIsOpened ] );
 
-	const { showInsertionPoint, setInserterInsertionPoint } = unlock(
+	const { setInserterInsertionPoint } = unlock(
 		useDispatch( blockEditorStore )
 	);
 
@@ -95,7 +95,6 @@ export default function QuickInserter( {
 			onSelect,
 		} );
 		setInserterInsertionPoint( { rootClientId, insertionIndex } );
-		showInsertionPoint( rootClientId, insertionIndex );
 	};
 
 	let maxBlockPatterns = 0;