Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Thanks for the review and updates 👍

Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
  • Loading branch information
mkaz and gziolo committed Jan 29, 2020
1 parent 680514b commit af192bd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions packages/scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ _Example:_
"lint:css": "wp-scripts lint-style",
"lint:js": "wp-scripts lint-js",
"lint:md:docs": "wp-scripts lint-md-docs",
"lint-md:js": "wp-scripts lint-md-js",
"lint:md:js": "wp-scripts lint-md-js",
"lint:pkg-json": "wp-scripts lint-pkg-json",
"packages-update": "wp-scripts packages-update",
"start": "wp-scripts start",
Expand Down Expand Up @@ -235,14 +235,14 @@ _Example:_
```json
{
"scripts": {
"lint-md:docs": "wp-scripts lint-md-docs"
"lint:md:docs": "wp-scripts lint-md-docs"
}
}
```

This is how you execute the script with presented setup:

* `npm run lint-md:docs` - lints markdown files in the entire project’s directories.
* `npm run lint:md:docs` - lints markdown files in the entire project’s directories.

By default, files located in `build` and `node_modules` folders are ignored.

Expand All @@ -259,14 +259,14 @@ _Example:_
```json
{
"scripts": {
"lint-md:js": "wp-scripts lint-md-js"
"lint:md:js": "wp-scripts lint-md-js"
}
}
```

This is how you execute the script with presented setup:

* `npm run lint-md:js` - lints markdown files in the entire project’s directories.
* `npm run lint:md:js` - lints markdown files in the entire project’s directories.

By default, files located in `build` and `node_modules` folders are ignored.

Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/scripts/lint-md-docs.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const hasIgnoredFiles = hasArgInCLI( '--ignore' ) || hasArgInCLI( '-i' ) ||
// markdownlint looks for .markdownlintignore in project direcotry, but how our
// scripts work we store the configs in the scripts/config directory
const defaultIgnoreArgs = ! hasIgnoredFiles ?
[ '--ignore', 'build', '--ignore', 'node_modules' ] :
[ '--ignore', '**/build/**', '--ignore', '**/node_modules/**' ] :
[];

const result = spawn(
Expand Down

0 comments on commit af192bd

Please sign in to comment.