Properly validate whether value exists

WordPress · Nov 6, 2023 · cd28877 · cd28877
1 parent e41a1cc
commit cd28877
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/edit-site/src/components/dataviews/in-filter.js b/packages/edit-site/src/components/dataviews/in-filter.js
@@ -9,13 +9,15 @@ import {
 const OPERATOR_IN = 'in';
 
 export default ( { filter, view, onChangeView } ) => {
-	let activeValue = view.filters.find(
+	const valueFound = view.filters.find(
 		( f ) => f.field === filter.id && f.operator === OPERATOR_IN
-	)?.value;
+	);
+
+	const activeValue =
+		! valueFound || ! valueFound.hasOwnProperty( 'value' )
+			? ''
+			: valueFound.value;
 
-	if ( ! activeValue ) {
-		activeValue = '';
-	}
 	return (
 		<SelectControl
 			value={ activeValue }