-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
List block: Add numbering type selection (#51186)
Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
- Loading branch information
1 parent
8f9ab38
commit d481efb
Showing
5 changed files
with
73 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
test/integration/fixtures/blocks/core__list__ol-with-type.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<!-- wp:list {"ordered":true,"type":"A"} --> | ||
<ol type="A"> | ||
<!-- wp:list-item --> | ||
<li>Item 1</li> | ||
<!-- /wp:list-item --> | ||
</ol> | ||
<!-- /wp:list --> |
21 changes: 21 additions & 0 deletions
21
test/integration/fixtures/blocks/core__list__ol-with-type.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
[ | ||
{ | ||
"name": "core/list", | ||
"isValid": true, | ||
"attributes": { | ||
"ordered": true, | ||
"values": "", | ||
"type": "A" | ||
}, | ||
"innerBlocks": [ | ||
{ | ||
"name": "core/list-item", | ||
"isValid": true, | ||
"attributes": { | ||
"content": "Item 1" | ||
}, | ||
"innerBlocks": [] | ||
} | ||
] | ||
} | ||
] |
20 changes: 20 additions & 0 deletions
20
test/integration/fixtures/blocks/core__list__ol-with-type.parsed.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
[ | ||
{ | ||
"blockName": "core/list", | ||
"attrs": { | ||
"ordered": true, | ||
"type": "A" | ||
}, | ||
"innerBlocks": [ | ||
{ | ||
"blockName": "core/list-item", | ||
"attrs": {}, | ||
"innerBlocks": [], | ||
"innerHTML": "\n\t<li>Item 1</li>\n\t", | ||
"innerContent": [ "\n\t<li>Item 1</li>\n\t" ] | ||
} | ||
], | ||
"innerHTML": "\n<ol type=\"A\">\n\t\n</ol>\n", | ||
"innerContent": [ "\n<ol type=\"A\">\n\t", null, "\n</ol>\n" ] | ||
} | ||
] |
5 changes: 5 additions & 0 deletions
5
test/integration/fixtures/blocks/core__list__ol-with-type.serialized.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<!-- wp:list {"ordered":true,"type":"A"} --> | ||
<ol type="A"><!-- wp:list-item --> | ||
<li>Item 1</li> | ||
<!-- /wp:list-item --></ol> | ||
<!-- /wp:list --> |
d481efb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in d481efb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5285823154
📝 Reported issues:
/test/e2e/specs/editor/blocks/navigation.spec.js
/test/e2e/specs/editor/blocks/navigation.spec.js
/test/e2e/specs/editor/blocks/navigation.spec.js