Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
@richtabor @MaggieCabrera
richtabor authored and MaggieCabrera committed Dec 4, 2023
1 parent f760a27 commit daf6fbc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/blocks/image.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ test.describe( 'Image', () => {
await page
.getByRole( 'button', { name: 'Publish', exact: true } )
.click();
await page.getByRole( 'button', { name: 'Upload all' } ).click();
await page.getByRole( 'button', { name: 'Upload' } ).click();

Check failure on line 732 in test/e2e/specs/editor/blocks/image.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 1

[chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 

  1) [chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 
    Error: locator.click: Error: strict mode violation: getByRole('button', { name: 'Upload' }) resolved to 2 elements:
        1) <button id=":rt:" type="button" tabindex="-1" data-comma…>…</button> aka getByLabel('Upload external image')
        2) <button type="button" class="components-button is-primar…>Upload</button> aka getByRole('button', { name: 'Upload', exact: true })

    =========================== logs ===========================
    waiting for getByRole('button', { name: 'Upload' })
    ============================================================

      730 | 			.getByRole( 'button', { name: 'Publish', exact: true } )
      731 | 			.click();
    > 732 | 		await page.getByRole( 'button', { name: 'Upload' } ).click();
          | 		                                                     ^
      733 |
      734 | 		await expect( page.locator( '.components-spinner' ) ).toHaveCount( 0 );
      735 |

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:732:56

Check failure on line 732 in test/e2e/specs/editor/blocks/image.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 1

[chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 

  1) [chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.click: Error: strict mode violation: getByRole('button', { name: 'Upload' }) resolved to 2 elements:
        1) <button id=":rt:" type="button" tabindex="-1" data-comma…>…</button> aka getByLabel('Upload external image')
        2) <button type="button" class="components-button is-primar…>Upload</button> aka getByRole('button', { name: 'Upload', exact: true })

    =========================== logs ===========================
    waiting for getByRole('button', { name: 'Upload' })
    ============================================================

      730 | 			.getByRole( 'button', { name: 'Publish', exact: true } )
      731 | 			.click();
    > 732 | 		await page.getByRole( 'button', { name: 'Upload' } ).click();
          | 		                                                     ^
      733 |
      734 | 		await expect( page.locator( '.components-spinner' ) ).toHaveCount( 0 );
      735 |

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:732:56

Check failure on line 732 in test/e2e/specs/editor/blocks/image.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 1

[chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 

  1) [chromium] › editor/blocks/image.spec.js:718:2 › Image › should upload through prepublish panel 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.click: Error: strict mode violation: getByRole('button', { name: 'Upload' }) resolved to 2 elements:
        1) <button id=":rt:" type="button" tabindex="-1" data-comma…>…</button> aka getByLabel('Upload external image')
        2) <button type="button" class="components-button is-primar…>Upload</button> aka getByRole('button', { name: 'Upload', exact: true })

    =========================== logs ===========================
    waiting for getByRole('button', { name: 'Upload' })
    ============================================================

      730 | 			.getByRole( 'button', { name: 'Publish', exact: true } )
      731 | 			.click();
    > 732 | 		await page.getByRole( 'button', { name: 'Upload' } ).click();
          | 		                                                     ^
      733 |
      734 | 		await expect( page.locator( '.components-spinner' ) ).toHaveCount( 0 );
      735 |

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:732:56

await expect( page.locator( '.components-spinner' ) ).toHaveCount( 0 );

Expand Down

0 comments on commit daf6fbc

Please sign in to comment.