-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Missing Core styles in CheckboxControl #11089
Comments
I think the screenshots are outdated but the checkboxes are still showing in a different style. |
I tested out rendering a However the way that checkbox inputs are styled today requires the Dashicon icon font to display its checked state. I think there are two options to achieve correct styling behavior for this component outside of wp-admin:
Are there simpler approaches? |
@jffng Can we replace it with the SVG instead, since @wordpress/components already contains those? So probably something more like option 2 but built-in in the component (not a new prop or something). |
Attempted a patch (#16551) that places a SVG component inside the label, to maintain expected behavior of the input. |
Describe the bug
When rendering the
CheckboxControl
component from the@wordpress/components
package outside of Core, there are some styling issues caused by the lack of the Core styles.To Reproduce
Expected behavior
As
@wordpress/components
pretends to work standalone, I expect the checkboxes to look like when the Core styles are present (see screenshots below).Screenshots
With Core styles
Without Core styles
Additional context
Issue found while integrating Gutenberg into Calypso (Automattic/wp-calypso#28101)
The text was updated successfully, but these errors were encountered: