Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Block: "Save" button inaccessible with any device #11519

Closed
mor10 opened this issue Nov 6, 2018 · 6 comments
Closed

Reusable Block: "Save" button inaccessible with any device #11519

mor10 opened this issue Nov 6, 2018 · 6 comments
Labels
[Block] Columns Affects the Columns Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended

Comments

@mor10
Copy link
Contributor

mor10 commented Nov 6, 2018

Describe the bug
When turning a Column block into a Reusable block, the Save button is virtually inaccessible using mouse, touch, or keyboard.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Column block.
  2. Add stuff inside the columns.
  3. Turn Column block into a Reusable block.
  4. Try clicking the Save button.

Expected behavior
Save button should be immediately available by mouse, touch, or keyboard.

Screenshots
Video demo of the bug: https://cloudup.com/c1rhJUKO0NG

Desktop:

  • OS: Tested on MacOS and Windows
  • Browser: Tested in Chrome and Firefox
  • Version: WordPress 5.0 Beta 3
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Block] Columns Affects the Columns Block Needs Testing Needs further testing to be confirmed. labels Nov 6, 2018
@designsimply
Copy link
Member

Adding a screenshot from the video demo for reference:

screen shot 2018-11-05 at 7 36 27 pm

@slimmilkduds
Copy link

I can confirm this issue.

@designsimply
Copy link
Member

Testing note: for cases reported here that are tested with WP 5.0 betas, we will want to check to make sure they are also happening with the plugin and if it's a WP-5.0-only issue we will want to move it to https://core.trac.wordpress.org/

@slimmilkduds
Copy link

I’m on plugin only (4.2.0)

@designsimply
Copy link
Member

Ace. Ditto. Just tested with WordPress 4.9.8 and Gutenberg 4.2.0 using Firefox 63.0.1 on macOS 10.13.6 and was able to see that the Save button is almost impossible to click when trying to make a columns block into a reusable block. (22s)

Thanks for testing @slimmilkduds !!

@designsimply designsimply removed the Needs Testing Needs further testing to be confirmed. label Nov 7, 2018
@mtias
Copy link
Member

mtias commented Nov 21, 2018

This should no longer be happening after #11904 and #11659

image

@mtias mtias closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants