Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaPlaceholder component errors when allowedTypes is not set. #11692

Closed
kadamwhite opened this issue Nov 9, 2018 · 0 comments · Fixed by #11694
Closed

MediaPlaceholder component errors when allowedTypes is not set. #11692

kadamwhite opened this issue Nov 9, 2018 · 0 comments · Fixed by #11694
Assignees
@kadamwhite
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Milestone
4.4

Comments

@kadamwhite
Copy link
Contributor

Describe the bug

When the MediaPlaceholder component is used and no allowedTypes property is provided, the component throws an error because it tries to access .length on an undefined value.

To Reproduce

  1. Create a custom block with the edit() method
  2. Attempt to insert your custom block into the editor
  3. Observe "The block has encountered an error and cannot be previewed" message.
  4. Observe a TypeError: Cannot read property 'length' of undefined in the console.

Expected behavior
The MediaUpload component specifies that allowedTypes an optional property; I would therefore expect MediaPlaceholder to behave the same, especially given that there is already code to check whether allowedTypes is unset elsewhere in MediaPlaceholder.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Ubuntu 18.04 / Chrome 70

Additional context

  • Gutenberg version: master
kadamwhite added a commit that referenced this issue Nov 9, 2018
@kadamwhite
Only check MediaPlaceholder allowedTypes array length if allowedTypes…
3989f10 
… prop exists

Fixes #11692

Adds basic unit test to demonstrate the bug described in #11692.
@kadamwhite kadamwhite mentioned this issue Nov 9, 2018
Merged
4 tasks
@ocean90 ocean90 added [Type] Bug An existing feature does not function as intended [Feature] Media Anything that impacts the experience of managing media labels Nov 10, 2018
@ocean90 ocean90 added this to the 4.4 milestone Nov 10, 2018
youknowriad pushed a commit that referenced this issue Nov 13, 2018
@kadamwhite @youknowriad
Only check MediaPlaceholder allowedTypes array length if prop exists (#…
eb4ed63 
…11694)

* Only check MediaPlaceholder allowedTypes array length if allowedTypes prop exists

Fixes #11692

Adds basic unit test to demonstrate the bug described in #11692.

* Initialize allowedTypes to [] instead of modifying conditional

* Reinstate array length check
This was referenced Nov 18, 2020
Open
Open
This was referenced Jun 23, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Jan 9, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadamwhite kadamwhite

Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Only check MediaPlaceholder allowedTypes array length if prop exists WordPress/gutenberg
2 participants
@kadamwhite @ocean90