Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3. RC1] Audio block disappears when align right or left in Chrome #11740

Closed
bph opened this issue Nov 11, 2018 · 3 comments · Fixed by #11749
Closed

[4.3. RC1] Audio block disappears when align right or left in Chrome #11740

bph opened this issue Nov 11, 2018 · 3 comments · Fixed by #11749
Assignees
Labels
[Block] Audio Affects the Audio Block Needs Testing Needs further testing to be confirmed.

Comments

@bph
Copy link
Contributor

bph commented Nov 11, 2018

Describe the bug
When I add an audio block to a paragraph block and align it left or right and then click outside the editing space, the audio block disappears.
It's still there, when I squint I can see the Audio label. . Clicking on it brings back the block into view

To Reproduce
Steps to reproduce the behavior:

  1. Add a new post
  2. Add a paragraph with some text
  3. add an audio block and align it right
  4. click outside the editor space.

Expected behavior
The audio block is still visible

Screenshots
Here is the video. http://recordit.co/898tjKTCao

When I looked closer I see some residue of the block and when I click on it, I get the tools bar and the display of the block back. See in this little video: http://recordit.co/px35d8sUae

Desktop (please complete the following information):
Seems to only happen with Google Chrome: 70.0
It works fine with Firefox Developer EDition
63.0b12
Video #3: http://recordit.co/UGsZDzGtu6

In reference of this PR: #11357

@bph bph changed the title 4.3. RC1 Audio block disappears when align right or left. [4.3. RC1] Audio block disappears when align right or left in Chrome Nov 11, 2018
@designsimply designsimply added Needs Testing Needs further testing to be confirmed. [Block] Audio Affects the Audio Block labels Nov 11, 2018
@dashkevych
Copy link

I've had the same issue when I was adding an audio block in the Editor. I've fixed it by adding this custom CSS to the editor styles:

[data-type="core/audio"][data-align="left"] .editor-block-list__block-edit,
[data-type="core/audio"][data-align="right"] .editor-block-list__block-edit {
  width: 50%;
}

@jasmussen jasmussen self-assigned this Nov 12, 2018
@jasmussen
Copy link
Contributor

On it, will have a fix in a bit.

jasmussen pushed a commit that referenced this issue Nov 12, 2018
Fixes #11740.

The audio block has no intrinsic width, and collapses if we don't set an explicit min-width on it. This PR does that.
@jasmussen
Copy link
Contributor

Fixed in #11749, thanks for the helpful report.

jasmussen added a commit that referenced this issue Nov 12, 2018
* Add min-width to audio block.

Fixes #11740.

The audio block has no intrinsic width, and collapses if we don't set an explicit min-width on it. This PR does that.

* Update changelog

* Move to style.scss instead.

* Refactor, address feedback.
youknowriad pushed a commit that referenced this issue Nov 12, 2018
* Add min-width to audio block.

Fixes #11740.

The audio block has no intrinsic width, and collapses if we don't set an explicit min-width on it. This PR does that.

* Update changelog

* Move to style.scss instead.

* Refactor, address feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Audio Affects the Audio Block Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants