Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Permalink 'Preview' to 'View' on published posts #14206

Closed
garretthyder opened this issue Mar 3, 2019 · 8 comments · Fixed by #16041
Closed

Update Permalink 'Preview' to 'View' on published posts #14206

garretthyder opened this issue Mar 3, 2019 · 8 comments · Fixed by #16041
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing)

Comments

@garretthyder
Copy link
Contributor

Is your feature request related to a problem? Please describe.
On a published post the 'Preview' in the top nav previews the current edits if any while the 'Preview' link in the Permalink modules will always link to the published page and not a preview.

screen shot 2019-03-03 at 1 52 53 am

Describe the solution you'd like
Can the 'Preview' verbiage in the Permalink module be updated to 'View' on published posts.

Describe alternatives you've considered
I've also thought it would be nice to have a View button in the topbar along with Preview on published posts to avoid having to find it in the Permalinks accordion as new users are unaware of how to view the post. When the wp-admin is available there's at least the link there, but when in full-screen mode this isn't available.

Thank you

@youknowriad youknowriad added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. and removed [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Mar 7, 2019
@youknowriad
Copy link
Contributor

I think the idea is that it means "preview of the link" but I may be wrong.

@youknowriad youknowriad added Needs Copy Review Needs review of user-facing copy (language, phrasing) Needs Design Feedback Needs general design feedback. labels Mar 7, 2019
@garretthyder
Copy link
Contributor Author

Thanks @youknowriad

I think my main gripe with the verbiage there is the 'Preview' button in the top actually generates a preview of the page and any changes appending ?preview_id=##&preview_nonce=XXXX&preview=true to the URL. Whereas the 'Permalink' provides the actual URL which takes you to the public page in it's current state (without any of your non-saved edits). As both of these are labelled as 'Preview' but do completely different actions I feel they should be distinctly defined by a slight change in verbiage.

When in draft the issue still pertains as they do two separate actions but in that context I'm ok with the Permalink stating Preview.

Aside from changing the Permalink section to say 'View' the other thought was to update the main Preview button that generates the preview with current changes to state 'Preview Changes' so it's clear that it would take you to the preview but also account for any changes you've made to the page without saving.

Hope that makes a bit of sense.
Thanks

@michelleweber
Copy link

Seems like "View published page" or "View page" for the permalink and "Preview changes" in the nav would be a clearer way to go.

@sarahmonster
Copy link
Member

Agreed that this could use better terminology to reflect the different statuses. For reference, here's a visualisation of the current situation:

current-situation

The problem here is that we use "preview" for two different links, that may potentially show different things, depending on whether the user has unpublished changes staged or not.

Since these two links go to different views, they should use different terminology so it's clear which is which.

Suggested solution

Whilst I love the idea of "Preview changes" in the nav, I think it'll just be too wordy/long for the available space, especially with translations coming into the mix. Instead, let's just change the text for the permalink link.

"View published page" is definitely the clearest and most explicit option here:

alternate-solution

...but it's also a bit wordy, and we might be able to make do with just "view page" instead:

suggested-solution

@garretthyder
Copy link
Contributor Author

Thanks @sarahmonster I appreciate the illustrations there, they definitely convey the issue much better than words.

I agree we probably can't change the Preview button version so cleaning up the link verbiage is the best approach. View or View page works nicely, although in most cases we're dealing with a post or CPT so maybe 'page' should be the name of the current CPT or just drop it to use 'View'.

@sarahmonster
Copy link
Member

My designer brain always wants pictures to go with everything. 😉

Agreed on the custom post type issue! Ideally, we'd swap out "page" in the above suggestion for "post" or the custom post type name, in the same way that post notifications do:

Screenshot 2019-05-08 at 00 23 17

@garretthyder
Copy link
Contributor Author

Awesome, thanks @sarahmonster I feel we're on the same page. Cheers

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 8, 2019
@mapk
Copy link
Contributor

mapk commented May 24, 2019

The solution here looks great! Let's update the Permalink wording to "View [page type]." Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants