Update permalink panel text to be 'View [postType]' instead of 'Preview' #16041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Jun 7, 2019
| { __( 'Preview' ) } | ||
| { sprintf( | ||
| /* translators: %s: post type singular name */ | ||
| __( 'View %s' ), postLabel |
There was a problem hiding this comment.
This should use the proper view_item label for this post type as generated by get_post_type_labels in WordPress. Anything else does not translate well.
swissspidy
reviewed
Jun 7, 2019
| @@ -148,6 +152,7 @@ export default compose( [ | |||
| postTitle: getEditedPostAttribute( 'title' ), | |||
| postSlug: getEditedPostAttribute( 'slug' ), | |||
| postID: id, | |||
| postLabel: get( postType, [ 'labels', 'singular_name' ] ), | |||
There was a problem hiding this comment.
This should use the view_item label.
|
Related Slack discussion concerning translatability (link requires registration): https://wordpress.slack.com/archives/C02QB2JS7/p1558731384027700 |
…_labels instead of 'Preview'
brentswisher
force-pushed
the
update/post-link-text
branch
from
454eba0
to
93ddfc4
Compare
|
Thank you for the speedy feedback @swissspidy and @aduth! I updated to use "view_item" and added a fallback to __( 'View Post' ) Also, I had missed that slack conversation @mapk , so sorry if I stepped on your toes here |
No toes were stepped on! 😃 |
gziolo
added
[Type] Copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14206 by replacing the text "Preview" in the permalink panel of the document settings with "View X" where X is the post type being edited. Preview can cause some confusion as there is also a "Preview" button at the top of the settings that does something different (generates a preview) where this link is just the currently live page.
How has this been tested?
Open a Post, see it now says "View Post"
Open a Page, see it now says "View Page"
Enable Gutenberg's custom post type plugin, add a PublicQueryPublic custom post, see that it says "View PublicQueryPublic"
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: