Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to keep drag handles in spotlight mode #14670

Closed
myleshyson opened this issue Mar 27, 2019 · 3 comments · Fixed by #15109
Closed

Add option to keep drag handles in spotlight mode #14670

myleshyson opened this issue Mar 27, 2019 · 3 comments · Fixed by #15109
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@myleshyson
Copy link
Contributor

Hi from UF Health again. We wanted to use spotlight mode and fixed toolbar mode as defaults for our admins and to 1) give them an easier focused way to navigate the blocks since most of them are not technically savvy and 2) with the fixed toolbar give them some parody with tools they already use like Word where the toolbar is up top. However, once we made spotlight mode default for users, we noticed the the drag handles disappeared.

I'm aware based on this comment #9569 (comment) that spotlight mode is for focusing. This is also the reason why we want it as the default for our users. However, our users also find that drag functionality extremely useful as they create their layouts. Ideally, we would like the option to keep drag handles in spotlight mode and make that decision ourselves as far as whether users need that functionality or not. Since we have 1000's of admins through our network, we're already hearing complaints about the drag handles disappearing forgetting that they switched to spotlight mode.

Again, maybe something either set in the block_editor_settings or a door in one of the data modules to hook in and enable drag handles would be great.

@jorgefilipecosta jorgefilipecosta added the Needs Design Needs design efforts. label Mar 28, 2019
@jorgefilipecosta
Copy link
Member

I confirmed that in spotlight mode the drag handles don't appear making moving the blocks very hard.

Hi @kjellr, @mapk, @melchoyce do you any thoughts about how the design should look for drag handles in spotlight mode?

@mapk
Copy link
Contributor

mapk commented Mar 29, 2019

I'm totally open to just adding them back the way they exist now. It's super frustrating trying to move blocks in spotlight mode without them.

This is what adding them back would look like.

spotlight-mode

@kjellr
Copy link
Contributor

kjellr commented Apr 1, 2019

Sounds good to me too. 👍

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. and removed Needs Design Needs design efforts. labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants