Restore block movers to focus mode #15109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Feature] Blocks
kjellr
requested review from
ellatrix,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
|
hi @kjellr I ran the code and the block mover is too close to the block toolbar, tried with twentynineteen and twentyfourteen
|
These were only included in focus mode, and end up causing overlap with the block mover butons.
|
Good catch, @draganescu! It's weird that didn't show up for me initially. 🤔 Anyway, I removed the style that was causing that in ecc932f. |
|
Yep, works for me 👍 👍 Just needs a code sanity check, I suppose! |
gziolo
approved these changes
Apr 26, 2019
|
Thanks, everyone! |
This was referenced Apr 29, 2019
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14670.
Currently Focus mode does not include a way to rearrange blocks. This PR corrects that by re-adding block movers to that mode. Conceptually, these seem fine to re-introduce because the movers shouldn't necessarily break your focus anyway: they only appear when you hover on a specific part of a block, and they fade away when you type.
Before:
After: