Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the React hooks eslint to our default eslint config #14676

Closed
youknowriad opened this issue Mar 28, 2019 · 1 comment · Fixed by #14995
Closed

Add the React hooks eslint to our default eslint config #14676

youknowriad opened this issue Mar 28, 2019 · 1 comment · Fixed by #14995
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Tool] ESLint plugin /packages/eslint-plugin [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@youknowriad
Copy link
Contributor

Also check if can avoid conflicts with the late variable declaration rule.

See here #14612 (comment)

cc @aduth
@youknowriad youknowriad mentioned this issue Mar 29, 2019
Merged
@swissspidy swissspidy added the [Tool] ESLint plugin /packages/eslint-plugin label Apr 2, 2019
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 2, 2019
@gziolo
Copy link
Member

gziolo commented Apr 2, 2019

Npm package: https://www.npmjs.com/package/eslint-plugin-react-hooks
Docs: https://reactjs.org/docs/hooks-rules.html

@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Apr 10, 2019
@youknowriad youknowriad mentioned this issue Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Tool] ESLint plugin /packages/eslint-plugin [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the default eslint react hooks config to the wordpress eslint package WordPress/gutenberg
3 participants
@youknowriad @gziolo @swissspidy