Add the default eslint react hooks config to the wordpress eslint package #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Automated Testing
youknowriad
requested review from
aduth,
ajitbohra,
ellatrix,
gziolo,
nerrad,
noisysocks,
oandregal,
ntwb and
talldan
as code owners
ntwb
approved these changes
Apr 16, 2019
|
@ntwb I already have a CHANGELOG entry |
gziolo
reviewed
Apr 16, 2019
| @@ -11,6 +11,22 @@ import { __ } from '@wordpress/i18n'; | |||
| import { Notice } from '@wordpress/components'; | |||
| import { useEffect } from '@wordpress/element'; | |||
|
|
|||
| function ContrastCheckerMessage( { tinyBackgroundColor, tinyTextColor, backgroundColor, textColor } ) { | |||
There was a problem hiding this comment.
Out of curiosity, what ESLint rule was triggered which enforced this refactor? I'm wondering what is the lesson learned.
There was a problem hiding this comment.
The reason is that you can't use hooks after "early returns"
gziolo
reviewed
Apr 16, 2019
| @@ -24,5 +25,7 @@ module.exports = { | |||
| 'react/no-children-prop': 'off', | |||
| 'react/prop-types': 'off', | |||
| 'react/react-in-jsx-scope': 'off', | |||
| 'react-hooks/rules-of-hooks': 'error', | |||
There was a problem hiding this comment.
Interesting, they don't provide the recommended preset.
youknowriad
commented
Apr 16, 2019
| @@ -24,5 +25,7 @@ module.exports = { | |||
| 'react/no-children-prop': 'off', | |||
| 'react/prop-types': 'off', | |||
| 'react/react-in-jsx-scope': 'off', | |||
| 'react-hooks/rules-of-hooks': 'error', | |||
| 'react-hooks/exhaustive-deps': 'warn', | |||
There was a problem hiding this comment.
I'm hesitant on the need of this one as we already have a valid use-case for extra deps, but I'm merging and we can try and see if it feels constraining.
This was referenced Apr 29, 2019
aduth
reviewed
Nov 22, 2019
| "_originalInput": "#666", | ||
| "_r": 102, | ||
| "_roundA": 1, | ||
| "_tc_id": 2, |
There was a problem hiding this comment.
yes, these snapshots are not that useful I think.
This was referenced Dec 9, 2019
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14676
This PR adds the default eslint config for react hooks (See https://reactjs.org/docs/hooks-rules.html) to the WordPress eslint config.
URLPopoverAtLinkcomponent. It's our use-case is legitimate though so I was wondering if we should remove the second rule (the warning) added here. cc @aduth