Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS: Undefined variable $theme-color (template-part/editor.scss) #23217

Closed
ItsJonQ opened this issue Jun 16, 2020 · 3 comments
Closed

SCSS: Undefined variable $theme-color (template-part/editor.scss) #23217

ItsJonQ opened this issue Jun 16, 2020 · 3 comments
Assignees
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ItsJonQ
Copy link

ItsJonQ commented Jun 16, 2020

In the latest master branch, I'm experiencing issues running npm run dev.
I get this error:

Build Progress: [                              ] 0%Error: Undefined variable: "$theme-color".
    at options.error (/Users/Q/Sites/@wordpress/gutenberg/node_modules/node-sass/lib/index.js:291:26) {
  type: 'Error',
  '$error': '$error',
  status: 1,
  file: '/Users/Q/Sites/@wordpress/gutenberg/packages/block-library/src/template-part/editor.scss',
  line: 67,
  column: 32,
  formatted: 'Error: Undefined variable: "$theme-color".\n' +
    '        on line 67 of packages/block-library/src/template-part/editor.scss\n' +
    '        from line 46 of packages/block-library/src/editor.scss\n' +
    '>> \t\t\tborder: $border-width solid $theme-color;\n' +
    '\n' +
    '   -------------------------------^\n'
}
Build Progress: [==============================] 100%

Taking a look at the file, it looks like it's using a $theme-color variable. I'm not too sure where that variable is defined though 🤔 .

Would we be able to replace that with another value?

To reproduce
Steps to reproduce the behavior:

  1. Pull latest master branch
  2. Run npm run dev
  3. See error in console
@ItsJonQ ItsJonQ added [Type] Bug An existing feature does not function as intended CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jun 16, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 16, 2020
@Addison-Stavlo
Copy link
Contributor

#23221 should fix this.

@Addison-Stavlo
Copy link
Contributor

The fix is merged and master is building again. This should be good to go! Sorry about that 😅 . Feel free to re-open if the issue persists.

@ItsJonQ
Copy link
Author

ItsJonQ commented Jun 17, 2020

@Addison-Stavlo No worries at all! 🤗 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants