-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template part previews to placeholder block #22760
Add template part previews to placeholder block #22760
Conversation
Co-authored-by: Enrique Piqueras <epiqueras@users.noreply.github.com>
Let's follow this up with: #22760 (comment). |
I'm seeing this error when running
In fact, it seems like Update: #23217 |
it must have been something in the merge since the build was passing here |
Super weird. |
I am seeing this in travis builds on another PR (#23007), but I started seeing it a couple hours before this PR merged? its definitely confusing me here... |
I cant build master because of this error. I wonder why
but now having it here is failing. |
maybe a file needs imported? |
#23221 should fix it. And that permalink I noted above was on the wrong branch, it looks like they changed to var(--wp-admin-theme-color) 11 hours ago. |
Description
An alternative exploration to #22612 as a potential step forward for issue #21218. Here, I have added the previews and selectable interface to the Template Part placeholder block. A handful of styles and use-async-list file were carried over from the inserter implementation.
The placeholder now has 2 sections divided by Tabs: one for selecting via previews and the other for creating the new template part.
The template part creation flow has been 'mostly' untouched for the time being. For this section I have removed the preview, updated the choose/create button and function to only support 'create', and updated the help text to guide the user.
This seems like a good step forward, but this will probably require some future iteration in style and creation flow in upcoming PRs.
How has this been tested?
Local docker environment in site/post editors.
Types of changes
Checklist: