Image editing

[ellatrix]

This is an issue to track what's left to do for image editing.

• There's an issue with server side cropping once the image has been edited several times. Needs investigation. Seems to be fixed with Image editing: preserve crop position through rotations #23374.
• Move zoom slider to toolbar. Move zoom slider to toolbar #22569 Cc @ItsJonQ @diegohaz
• Remove other buttons in the toolbar when editing the image. Image editing: remove other block toolbar buttons while editing #23707
• Ensure errors reported from the API are communicated to the user. Image Editor: Stabilize endpoint #23536
• Clean up the experimental REST API endpoint.
• Are edits applied to original image? Fix generating file names for edited files, and use wp_unique_filename() #23440
• Is the edited file name good? Fix generating file names for edited files, and use wp_unique_filename() #23440
• Test on mobile devices.

Nice to have.

• Flipping.
• Animations. Add transform effects to image editing #22566.
• Allow editing of external images.
• Maybe add processing messages. Snackbar notices for image editing #22573

[ellatrix]

@jasmussen @MichaelArestad Would love your thoughts and further help regarding the design, maybe in particular the zoom controls.

[jasmussen]

Some good feedback from #23284 (comment) worth reading for context. Many are already action items here.

[ellatrix]

@jasmussen I think I've moved those action items here :)

[TimothyBJacobs]

We're going to need phpunit tests on the endpoint as well.

[TimothyBJacobs]

Opened a PR for the REST endpoint, #23368.

[MichaelArestad]

I must be missing something. I loaded up master to test, but this is what I'm seeing:

I don't see the tools shown in some of the gifs from #23284. I also see "Crop" instead of the crop icon. Is there another branch I should be testing on?

I'm also noticing sometimes the caption toolbar is open when the zoom is open:

[jasmussen]

Some things had to change so as to apply a single operation on apply, rather than immediately after each. Some of that is tracked in #23350, and I'll be taking a stab today.

[jasmussen]

Was not an action item on this list, but was on feedback in #23284 (comment). #23387 changes the "Edit" button to be the crop icon. It becomes a bit of an umbrella button for even the rotate image feature, but at least it's one click.

On that note, in order to truly address this item:

Remove other buttons in the toolbar when editing the image.

we really need a classname on the image toolbar to specifically target with some handy display: none;s. Ideally instead of this:

It should look like this:

It would be trivial if we could specifically target the cropping "mode" of the toolbar, and it would really clean up the flow.

[jasmussen]

In #23418, I did a bunch of cleanup with the zoom slider. I still think we should move it to the block toolbar, but in case that's an onerous effort, this can potentially serve as a holdover.

[mtias]

I think we can close this as the separate issues stand on their own.