Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Embeds set to aligh left/right disappear in the editor #24845

Closed
aristath opened this issue Aug 27, 2020 · 1 comment · Fixed by #24847
Closed

Video Embeds set to aligh left/right disappear in the editor #24845

aristath opened this issue Aug 27, 2020 · 1 comment · Fixed by #24847
Assignees
@noisysocks
Labels
[Block] Embed Affects the Embed Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@aristath
Copy link
Member

Describe the bug
Reported in https://core.trac.wordpress.org/ticket/51053

To reproduce
Steps to reproduce the behavior:

  1. Using the twentytwenty theme add a video in the editor
  2. Align the block to the left
  3. Save the post
  4. Reload the page and watch as the video disappears.

Editor version:

  • WordPress version: 5.5
  • Both using Gutenberg as a plugin and when not installed

Desktop (please complete the following information):

  • OS: Linux
  • Browser Firefox
  • Version 80.0
@aristath aristath added [Type] Bug An existing feature does not function as intended [Block] Embed Affects the Embed Block [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. labels Aug 27, 2020
aristath added a commit to aristath/gutenberg that referenced this issue Aug 27, 2020
@aristath
fixes WordPress#24845
64a06ee
@aristath aristath mentioned this issue Aug 27, 2020
Merged
@rebeccahum
Copy link

Is this still occurring in 5.5.1? Attempted to reproduce on Chrome and couldn't.

@rebeccahum rebeccahum added the Needs Testing Needs further testing to be confirmed. label Sep 28, 2020
noisysocks pushed a commit that referenced this issue Oct 29, 2020
@aristath
fixes #24845 (#24847)
b103272
@noisysocks noisysocks mentioned this issue Oct 29, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 29, 2020
talldan pushed a commit that referenced this issue Oct 29, 2020
@aristath @talldan
fixes #24845 (#24847)
dda511c
noisysocks added a commit that referenced this issue Oct 29, 2020
@noisysocks @alexandec
@talldan @jasmussen @mtias @ntsekouras @aristath @jorgefilipecosta @youknowriad @mkaz
WordPress 5.5.2 Backports (#26562)
0f83d77 
* Refactor BlockMover to use React hooks (#24774)

* Add drag handle to block toolbar (#24852)

* Add drag handle to block mover component

* Switch draggable chip to reflect toolbar layout

* Use drag cursor

* Hide drag handle on mobile or in top toolbar mode

* Adjust handle and structure.

* Size the switcher.

* Adjust mover.

* Update icon for handle.

* Update movers buttons.

* Fix groups.

* Focus for switcher.

* Handle focus.

* Fix top toolbar.

* Popover fix.

* Fix spacing issue.

* Harmonize spacing.

* Try small independen transition for up / down.

* Reduce motion.

* use dragHandle icon in draggable chip

* Make draggable chip use same icon as toolbar

* Revert "Make draggable chip use same icon as toolbar"

This reverts commit d031006.

* Revert offset change and ensure cursor does not overlap chip block info

* Update snapshots to reflect chevron icon change

Co-authored-by: jasmussen <joen@automattic.com>
Co-authored-by: Matías Ventura <mv@matiasventura.com>

* Fix issue with single block. (#25107)

* Remove animation from mover buttons. (#25728)

The animation was intended to better convey direction, and were added as an experiment. It doesn't seem successful, so let's remove it again.

* add label in drag and drop button (#25606)

* Change toolbar drag remove labels (#25614)

* Refactor toolabar drag+remove labels

* fix tests

* fixes #24845 (#24847)

* Fix: Post schedule label showing wrong time if site and user timezones did not match (#26212)

* URLInput: Use debounce() instead of throttle() (#26529)

Wait until the user finishes typing before sending an AJAX request. This
ensures that there isn't an AJAX request sent every 200 ms while the
user is typing.

* Update browserlist dependency (#24756)

* Fix composer test failures due to invalid lock (#26472)

* Update package-lock.json

* Set dev environment to use WordPress 5.5

Co-authored-by: Chris Alexander <cmalex@gmail.com>
Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
Co-authored-by: jasmussen <joen@automattic.com>
Co-authored-by: Matías Ventura <mv@matiasventura.com>
Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com>
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
Co-authored-by: Jorge Costa <jorge.costa@automattic.com>
Co-authored-by: Riad Benguella <benguella@gmail.com>
Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Block] Embed Affects the Embed Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix left and right alignments for video embeds aristath/gutenberg
3 participants
@aristath @noisysocks @rebeccahum