Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When themes don't support widgets the editor looks broken #26153

Closed
draganescu opened this issue Oct 15, 2020 · 2 comments · Fixed by #32420
Closed

When themes don't support widgets the editor looks broken #26153

draganescu opened this issue Oct 15, 2020 · 2 comments · Fixed by #32420
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

In the classic widgets editor when a theme has no widget support we see a message. In the new widgets editor we get one widget area with inactive widgets and no message.

To reproduce:

  1. Have Gutenberg plugin installed
  2. Install a no widget theme such as Fonts
  3. Go to Appearance > Widgets notice there are no widget areas, except "Inactive widgets"
  4. Manually go to /wp-admin/widgets.php, notice the message

Screenshots:

Classic widgets editor

Screenshot 2020-10-15 at 15 44 58

Block-based widgets editor

Screenshot 2020-10-15 at 15 45 15

@draganescu draganescu added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 15, 2020
@mapk
Copy link
Contributor

mapk commented Nov 9, 2020

I just tested this with the Fonts theme. Is there a reason we show the Widgets menu item in the wp-admin menu if a theme does not support widget areas? Can we just hide that menu option?

Example of Fonts theme & Widgets menu option still visible

Screen Shot 2020-11-09 at 12 06 14 PM

If there remains a reason to keep this option available even if the theme doesn't support widgets, we might be able to make use of the existing notifications in Gutenberg.

Existing notifications

Screen Shot 2020-11-09 at 12 43 58 PM

Mock up of proposed design

No widget areas

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 9, 2020
@noisysocks
Copy link
Member

Noting that WordPress/wordpress-develop#1308 contains a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants