Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template part block: Choose another dropdown is confusing #29300

Closed
david-szabo97 opened this issue Feb 24, 2021 · 4 comments · Fixed by #29257
Closed

Template part block: Choose another dropdown is confusing #29300

david-szabo97 opened this issue Feb 24, 2021 · 4 comments · Fixed by #29257
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@david-szabo97
Copy link
Member

Template part block's toolbar includes a dropdown button which is called "Choose Another".
image

It would make sense to replace this with Replace or with a more meaningful icon.

We use Replace in a couple of places, for example the Image block:
image

@david-szabo97 david-szabo97 added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 24, 2021
@vindl vindl added the Needs Design Feedback Needs general design feedback. label Feb 24, 2021
@mtias
Copy link
Member

mtias commented Feb 26, 2021

@jameskoster is looking at this here #29257

@jameskoster jameskoster linked a pull request Feb 26, 2021 that will close this issue
@jameskoster
Copy link
Contributor

Alternatively, might we consider removing this altogether for now? It is as yet unclear how important this behaviour will be compared to something like selecting a pattern inside a Template Part, see: #28737.

Since it would still be possible to "switch" a template part by deleting and re-inserting the block, it seems fairly safe to remove this for now, if we want to.

Thoughts?

@mtias
Copy link
Member

mtias commented Feb 26, 2021

Yes, or keep it as an "advanced" action. I don't think it warrants a prominent placement. The integration of patterns in template parts is a much more important flow.

@jameskoster
Copy link
Contributor

I think that being able to switch the template part 'variant' and change the area in the "Advanced" section of the Inspector could lead to some confusing interactions.

Screenshot 2021-02-26 at 13 41 12

Imagine you change the area to "Footer". Suddenly the variant you selected is no longer valid... what would happen here?

I'm going to chalk this one up as another argument for not having these controls available at all, until you're editing the template part in isolation. It feels too confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants