Template Part: Update switching trigger #29257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +27 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Addison-Stavlo
force-pushed
the
update/template-part-switch-button
branch
from
7289088 to
14ae17c
Compare
Addison-Stavlo
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently possible to switch Template Parts by clicking the chevron icon in the Toolbar:
The icon used here is however a little ambiguous.
In this PR I'm exploring alternatives that might better communicate what will happen when the button is clicked. My initial iteration takes inspiration from the Image block, and uses a simple text button with "Replace" as a label:
Edit: It is worth noting that in the long term I suspect this affordance will move to the Transform menu. But that is not 100% clear yet. This is very much proposed as an interim step that improves the existing UX.