Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets selected by the user are not applied to the Post Title block #29381

Closed
oandregal opened this issue Feb 26, 2021 · 0 comments · Fixed by #29533
Closed

Presets selected by the user are not applied to the Post Title block #29381

oandregal opened this issue Feb 26, 2021 · 0 comments · Fixed by #29533
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Feb 26, 2021

This is a bug that only affects the Post Title block at the moment, but would affect more as soon as the block selectors specificity is higher than the user-selected styles, as per #29155 in which we're opening up the block selectors to target inner blocks.

Step-by-step reproduction instructions

  • Use a theme with support for FSE (templates) and Global Style (theme.json), such as TT1-blocks.
  • Via theme.json target the post title for color styles by adding:
"core/post-title/h2": {
    "color": {
        "text": "green",
        "background": "yellow"
    }
}
  • Go to the editor, add a post title select some text and background preset colors for it (not custom).
  • Publish the post and go to the front end.

The expected behavior would be that the user choices are respected. Instead, the values of theme.json are applied.

@oandregal oandregal added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended labels Feb 26, 2021
@oandregal oandregal changed the title Presets applied by the user are applied to the Post Title block Presets selected by the user are not applied to the Post Title block Feb 26, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant