Global Styles: fix specificity conflict of blocks with single classes as selectors #29378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
changed the title
oandregal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
fix/load-presets-after-blocks
branch
from
8d5e904
to
4302800
Compare
|
I came here to open this issue, that I had noticed with the site title block. The PR solves the problem for me. I tested this in TT1 Blocks, which has a theme.json setting for the site title font size: |
oandregal
force-pushed
the
fix/load-presets-after-blocks
branch
from
4302800
to
4534066
Compare
Thanks for looking for issues/PRs before submitting your report, Carolina. |
20 tasks
This is because we want the source order specificity for presets to be higher than for block styles, to fix cases in which the block selector has the same specificity as the class. Ex: - an user attaches the .has-white-color class to a block of type "my block", whose selector is .wp-block-my-block. - the themes targets the color of "my block" as well, generating a rule with the .wp-block-my-block selector. The color applied to the block that was tweaked by the user will be the last in the source.
oandregal
force-pushed
the
fix/load-presets-after-blocks
branch
from
4534066
to
2d49b36
Compare
aristath
approved these changes
Mar 2, 2021
|
Going to merge this one as it is a dependency of #29382 and the two test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which the source order of blocks whose CSS selector is a class overrides user styles for preset values.
How to reproduce
The expected result would be that the user colors were respected. Instead, what happens is that the theme's colors are applied.
What's the fix
Load the preset classes after the block styles, so the last rule wins.
Note that there's a different issue with block selectors whose selector specificity is higher than the selector of user-selected styles (a class). #29381