Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT1 Blocks: The font size of the site title cannot be changed from the default. #227

Closed
miminari opened this issue Mar 2, 2021 · 4 comments

Comments

@miminari
Copy link
Member

miminari commented Mar 2, 2021

I did some tests following this post.
https://make.wordpress.org/test/2021/02/18/fse-program-testing-call-2-build-a-homepage-with-site-editing-blocks/

And I noticed the font size of the site title could not be changed from the default.

If you change the font size of your site from the settings, it will not change on the front view.

Editor View:
Editor View

Front View:
Front View

This is probably because no style is given to .wp-block-site-title.has-extra-large-font-size, and similar class names.


Verification environment

  • TT1 Blocks Version: 0.4.4

  • Gutenberg 10.0.2

  • WordPress 5.6.2

  • Mac OS Big Sur 11.1

  • Chrome 88.0.4324.192

@carolinan
Copy link
Collaborator

Hi
This is related to Gutenberg and not the theme itself, it will (hopefully) be fixed with WordPress/gutenberg#29378

@miminari
Copy link
Member Author

miminari commented Mar 2, 2021

Thank you for reply.
Does this mean that it's better not to have more styles in the block based theme than can be specified in theme.json?

@aristath
Copy link
Member

aristath commented Mar 2, 2021

Does this mean that it's better not to have more styles in the block based theme than can be specified in theme.json?

It depends on the styles. Basic and "universal" styles should be in the theme.json file, while more opinionated things that make a theme stand-out and add some character would still be in CSS files.

@aristath
Copy link
Member

aristath commented Mar 2, 2021

I'll go ahead and close this thread since it's not related to the TT1 theme and we already have the other ticket in Gutenberg 👍

@aristath aristath closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants