Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Justify right and clicking right button the toolbar goes outside the layout screen, #30693

Closed
paaljoachim opened this issue Apr 9, 2021 · 7 comments
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended

Comments

@paaljoachim
Copy link
Contributor

Description

When "Justify items right" and the button moves to the right clicking the right button the toolbar goes outside the canvas/layout area.

Step-by-step reproduction instructions

Please list the steps needed to reproduce the bug. For example:

  1. Add a Buttons Block.
  2. Click to Justify items right.
  3. Click the right justified button.
  4. Notice that the toolbar goes outside of the canvas area.

Expected behaviour

To see the toolbar within the canvas area.

Actual behaviour

Toolbar goes outside the canvas area.

Screenshots or screen recording (optional)

Screen Shot 2021-04-10 at 00 32 52

Buttons-Justy-right.mp4

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: 10.3.2
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Twenty Twenty One.
@paaljoachim paaljoachim added [Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended labels Apr 9, 2021
@annezazu
Copy link
Contributor

As part of the ninth call for testing for the FSE Outreach, this experience of right aligning the button block came up. However, in this case, the problem is that if the buttons block is aligned right, upon clicking on it, it reverts back to being aligned left as shown below:

Focusing on the “Covid” button when it’s aligned-right makes it jump back to aligned left.

align.button.mov

I'm wondering if this might be due to some fix that addressed this original issue so I wanted to tie the two together here. Happy to open a new issue if that works better!

@annezazu
Copy link
Contributor

annezazu commented Aug 16, 2021

Ah ha, I found a fix for the issue I mentioned here: #33739. I then replicated the issue originally described here and can still replicate:

Screen Shot 2021-08-16 at 5 18 38 PM

@jasmussen
Copy link
Contributor

Is this still an issue?

resizing

@annezazu
Copy link
Contributor

annezazu commented Oct 3, 2022

I can replicate a version of this but it has more to do with this issue IMO #34466

toolbar.mov

@annezazu
Copy link
Contributor

annezazu commented Oct 3, 2022

I'd prefer to close this out as a result and leave an updated comment there. Does that work for you @paaljoachim or are you still able to replicate this?

@jasmussen
Copy link
Contributor

Yep, that issue is definitely about block toolbar width, so I think we can close this one.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Oct 3, 2022

It works for me (mostly I do notice this #34466). The issue I mentioned has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants